fix(VirtualScroll): initialise differ with trackByFn #11492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
suggested changes
May 3, 2017
| if (!isPresent(val)) return; | ||
| this._virtualTrackBy = val; | ||
| if (isPresent(this._records)) { | ||
| this._differ = this._iterableDiffers.find(this._records).create(this.virtualTrackBy); |
There was a problem hiding this comment.
can we move the this._differ creation logic to a new function? maybe _updateDiffer. it is duplicated in here and virtualScroll.
Also, can you add a new-line after @input()?
There was a problem hiding this comment.
Wasn't sure if you prefer I overwrite last commit or add a new one, so I went with the safer choice.
|
The second commit appears to break the fix - the |
|
Oh yes. You are correct. isBlank(this.differ) check should not be there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
VirtualScroll trackByFn has no effect due to the random order that Angular interprets input values.
Changes proposed in this pull request:
Virtual TrackByFn is changed into as setter input, that redefines the change detection mechanism as soon as trackBy is parsed, to take into account the provided function
Ionic Version: 3.x
Fixes: #7531
Related to #11294