fix(button): rtl fix for md ripple effect

[sijav]

Short description of what this resolves:

This will fix ripple effect on material design which were showing displaced of touch click.

Changes proposed in this pull request:

• remove the include position and instead use absolute values.

Ionic Version: 3.x

Fixes: #11211

[AmitMY]

First, know that this won't pass linting, as the properties are above an @include

Because of the new changes, this needs to be inside a @include multi-dir() { which goes at the end of the selector. When that is done, it can be merged. (Didn't merge before as I knew there will be changes with multi-dir)

[sijav]

Oh I get it now thanks. Will do

[sijav]

@AmitMY is it alright now?

[AmitMY]

Can you remove this empty line + move //scss-lint:disable... to the first row of the mixin? something like

@include multi-dir() {
  // scss-lint:disable PropertySpelling
  top: 0;
  left: 0;
}

(because we don't won't to ignore it for the entire block)

[sijav]

@AmitMY sure but css lint gave me error because I hadn't put empty line in between ... I think it was because I had order problems? I'll commit the new changes asap

[AmitMY]

Oh sure, linter rules over me ;)
So just that disable comment if you can

[sijav]

@AmitMY With this commit I get this PropertySortOrder: Property 'left' should have an empty line separating it from the previous group of properties ending with 'top'

[AmitMY]

@sijav

Oh sure, linter rules over me ;)

so final thing here, add an empty line there, and this seems good. Sorry for the messiness

[brandyscarney]

Looks great, thank you!