Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loading): add enableBackdropDismiss to Loading #11937

Merged
merged 1 commit into from
Jun 8, 2017
Merged

feat(loading): add enableBackdropDismiss to Loading #11937

merged 1 commit into from
Jun 8, 2017

Conversation

imgx64
Copy link
Contributor

@imgx64 imgx64 commented Jun 6, 2017

Short description of what this resolves:

Add enableBackdropDismiss to Loading.

Changes proposed in this pull request:

  • Loading indicator can now be dismissed by the user if enableBackdropDismiss option is set.

Ionic Version: 1.x / 2.x / 3.x
3.x

Fixes: #7975

Copy link
Contributor

@manucorporat manucorporat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc @brandyscarney

@brandyscarney brandyscarney merged commit d0ae810 into ionic-team:master Jun 8, 2017
@brandyscarney
Copy link
Member

Looks great, thank you!

@imgx64 imgx64 deleted the loading-backdrop-dismiss branch June 11, 2017 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants