Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(range): allow fractional steps #12153

Closed
wants to merge 54 commits into from
Closed

feat(range): allow fractional steps #12153

wants to merge 54 commits into from

Conversation

AmitMY
Copy link
Contributor

@AmitMY AmitMY commented Jun 25, 2017 •
edited
Loading

WIP, it works, but snaps fractional values even without snap.

Short description of what this resolves:

I want a range from 0.5 to 1.5 (step: 0.1), and while I can use an intermediate variable, with range 1-15, I can't use pin for that.

Changes proposed in this pull request:

  • Don't round the step

Ionic Version: 3.x

Closes: #6812 #9098

brandyscarney and others added 30 commits June 12, 2017 13:51
@brandyscarney
style(util): remove commented out test css
a91a68e
@Manduro @manucorporat
fix(refresher): border should only show when pulled (ionic-team#12015)
47e3c70 
fixes ionic-team#10994
@manucorporat
fix(keyboard): big keyboard/input refactor
c10f72b 
fixes ionic-team#9699
fixes ionic-team#11484
fixes ionic-team#11389
fixes ionic-team#11325
fixes ionic-team#11291
fixes ionic-team#10828
fixes ionic-team#11291
fixes ionic-team#10393
fixes ionic-team#10257
fixes ionic-team#9434
fixes ionic-team#8933
fixes ionic-team#7178
fixes ionic-team#7047
fixes ionic-team#10552
fixes ionic-team#10393
fixes ionic-team#10183
fixes ionic-team#10187
fixes ionic-team#10852
fixes ionic-team#11578
@manucorporat
Merge branch 'keyboard-fixes'
6dee17b
@manucorporat
fix(input): add correct translate3d for rtl
ef85ba6 
thanks @Khalid-Nowaf

fixes ionic-team#11745
fixes ionic-team#11211
@Manduro @manucorporat
fix(input): use all supported attributes on both textareas and inputs (…
8041eed 
…ionic-team#12028)
@manucorporat
fix(input): better handling of attributes
9f86e10
@manucorporat
fix(textarea): apply classes properly
dc958c3
@Manduro @manucorporat
fix(input): slightly longer delay for autofocus (ionic-team#12037)
54ac2e3
@danbucholtz
chore(changelog): 3.4.0 release
2791c40
@danbucholtz
chore(dependencies): update package version to 3.4.0
f149c5e
@danbucholtz
chore(github): update issue template plunkr to 3.4.0 version
3564bcf
@manucorporat
fix(input): prevent duplicated tabIndex (ionic-team#12043)
7a1342c 
fixes ionic-team#7178
@manucorporat
refactor(overlay): simplify focusOutActiveElement (ionic-team#12023)
2743c63
@zakton5 @manucorporat
feat(select): add compareWith Input for object value comparison (ioni…
c7645ee 
…c-team#11965)

fixes ionic-team#6625
@manucorporat
fix(highlight): selected tab might be null
5a5da39 
fixes ionic-team#12054
@danbucholtz
chore(changelog): add upgrade instructions for 3.4.0
1a4aacf
@manucorporat
fix(sliding-item): super slow device does get correct classes
6193560 
fixes ionic-team#11988
@AmitMY @manucorporat
feat(item-reorder): add side support (ionic-team#11642)
63f728f 
fixes ionic-team#11637
@manucorporat
perf(item): button-effect is hidden for non buttons
8bd2f24
@manucorporat
style(reorder): using const
7803998
@dudeofawesome @manucorporat
fix(tabs): properly align tabs highlight (ionic-team#11619)
a8731df 
When `Tabs` are nested within each other, the highlight can get
misaligned. This prevents that by ensuring the affected
`.tab-highlight` is a direct child of the targeted `Tabs`.
@danbucholtz
chore(changelog): fix typo, update deps to latest
877d821
@brandyscarney
fix(themes): change default app-direction
1ca7df7
@brandyscarney
chore(ionic): release 3.4.1
5094fee
@brandyscarney
fix(rtl): use multi direction in order to override the default ltr
70b5b6b
@brandyscarney
chore(ionic): release 3.4.2
d8b65da
@manucorporat
fix(select): floating label
e3a8d27 
fixes ionic-team#12068
@danbucholtz
feature(navigation): modify urls to support multiple root level navs/…
5cad965 
…tabs

* wip

* wip

* progress

* wippy skippy

* getting there

* all tests passing except goBack

* unit tests pass again boi

* goBack tests pass

* great success

* the good stuff
@danbucholtz
chore(build): strictly enforce metadata
00fbded
danbucholtz and others added 16 commits June 20, 2017 13:26
@danbucholtz
refactor(app): refactor app slightly to maintain backwards compatibility
58e1d79
@danbucholtz
refactor(navigation): refactor nav-controller-base to maintain backwa…
1beef75 
…rds compatibility
@danbucholtz
fix(navigation): fallback to name if component does not exist on segment
30f69c8
@danbucholtz
add href for additional testing
fba6ff0
@janpio @mhartington
docs(api): angularjs to angular
86495e1 
Closes ionic-team#12101
@AmitMY
feat(range): allow decimal steps
a678df2
@danbucholtz
feature(navigation): better browser back/forward button support
0f5c47d 
* test(nav): add third page to nav/simple-nav

* progress

* workin'

* updates

* updates
@danbucholtz
fix(tabs): use segment if it exists even if component exists
016b90d
@mhartington
docs(menu): fix link to menucontroller
bc7bb21
@manucorporat
fix(select): _inputUpdated should not be called manually
8dc08f9
@danbucholtz
chore(changelog): 3.5.0 changelog
a92d805
@danbucholtz
chore(changelog): additional nav change details
048af1b 
additional nav change details
@danbucholtz
chore(dependencies): update app-scripts to 1.3.11, add npm 5 support
5771543 
update app-scripts to 1.3.11, add npm 5 support
@danbucholtz
chore(dependencies): lock file updated
a7e5fa7
@danbucholtz
feat(navigation): support for named ion-nav/ion-tabs to improve url i…
486bff0 
…n the short term

support for named ion-nav/ion-tabs to improve url in the short term
@danbucholtz
fix(navigation): mark as not transitioning on success in addition to …
48b3243 
…'_transitionFinish', provide no

mark as not transitioning on success in addition to '_transitionFinish', provide note as to why we
want it in both places
@PAFsec
Copy link

PAFsec commented Jul 3, 2017

Hello,

Your fix does not work as the value is after rounded again later in the code.

this issue is already referenced here #6812 and #9098

@AmitMY
Copy link
Contributor Author

AmitMY commented Jul 3, 2017

I like that, thanks!
That solution does not fully work as well, as there is a Math.round on step, and I don't like needing to specify resolution. I changed my solution a bit, to incorporate the resolution, but it self calculates it so there is no need to give it as an input.
I also think that fractional min and max are a good thing, which that solution does not do.

@PAFsec
Copy link

PAFsec commented Jul 11, 2017 •
edited
Loading

Ah, true, did not think of that !

Is it working well with your fractional step ? Because with the solution given in the two other issues, I stated that there was a kind of shaky behavior on the knob.

Thanks,

@AmitMY
Copy link
Contributor Author

AmitMY commented Jul 11, 2017

@PAFsec Yeah, this is not perfect, it "snaps fractional values even without snap" weirdly, but I think that is probably a small fix.. would love some team feedback on this

@Ionitron
Copy link
Collaborator

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!

@Ionitron Ionitron closed this Mar 12, 2018
@nielsswinkels nielsswinkels mentioned this pull request Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Range slider with float step size