fix(nav): ionViewCanLeave does not break navigation #8410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the NavController does the canLeave/canEnter challenge only when the navigation change requires a transition.
This logic leads to an important bug when canLeave or canEnter returns
false
(i.e. the transition has been cancelled) but the pages have been already removed from the stack.This PR introduces a new logic (that of course passes all the current unit tests):
This way if canLeave returns false, we have not touched the stack yet.
This bug can be reproduced with the following code, the simulates returning false a couple of times, then return true:
It breaks the navigation 100% of the times
fixes #8408