fix(action-sheet): follows MD spec #8736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should update Windows to match this, and then this LGTM. 👍 |
manucorporat
force-pushed
the
fix-md-action-sheet
branch
2 times, most recently
from
fd04eca to
40ca9eb
Compare
manucorporat
force-pushed
the
fix-md-action-sheet
branch
3 times, most recently
from
f78835a to
a2b2f3b
Compare
|
@brandyscarney done! MD and WP, only CSS |
manucorporat
force-pushed
the
fix-md-action-sheet
branch
from
a2b2f3b to
2db085b
Compare
|
Looks great. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
TOP: Native Material Design
BOTTOM: Ionic
BEFORE:
AFTER:
Actionsheet without header didn't follow the spec, now it does:
BEFORE:
AFTER:
fixes #8663