Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ActionSheet across all the platforms #8663

Closed
manucorporat opened this issue Oct 12, 2016 · 1 comment · Fixed by #8736
Closed

Clean up ActionSheet across all the platforms #8663

manucorporat opened this issue Oct 12, 2016 · 1 comment · Fixed by #8736
Assignees
@bensperry @brandyscarney
Milestone
2.0.0-rc.2

Comments

@manucorporat
Copy link
Contributor

manucorporat commented Oct 12, 2016 •
edited
Loading

IOS: could we make the icons look better in iOS? @bensperry
screen shot 2016-10-12 at 23 34 43

MD: looks like the icons have been displaced
screen shot 2016-10-12 at 23 34 58

WP: displaced icons and some texts are not longer aligned vertically
screen shot 2016-10-12 at 23 35 09

ping @brandyscarney
@jgw96 jgw96 added css labels Oct 12, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Oct 16, 2016
@manucorporat
fix(action-sheet): follows MD spec
dbd1502 
references ionic-team#8663
@manucorporat manucorporat mentioned this issue Oct 16, 2016
Merged
@manucorporat
Copy link
Contributor Author

MD regression is fixed with: #8736

manucorporat added a commit to manucorporat/ionic that referenced this issue Oct 22, 2016
@manucorporat
fix(action-sheet): follows MD spec
fd04eca 
references ionic-team#8663
manucorporat added a commit to manucorporat/ionic that referenced this issue Oct 22, 2016
@manucorporat
fix(action-sheet): follows MD spec
40ca9eb 
references ionic-team#8663
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 1, 2016
@manucorporat
fix(action-sheet): follows MD spec
f39b315 
references ionic-team#8663
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 1, 2016
@manucorporat
fix(action-sheet): follows MD spec
f78835a 
references ionic-team#8663
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 1, 2016
@manucorporat
fix(action-sheet): follows MD spec
a2b2f3b 
references ionic-team#8663
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 3, 2016
@manucorporat
fix(action-sheet): Clean up ActionSheet across all the platforms
2db085b 
fixes ionic-team#8663
brandyscarney pushed a commit that referenced this issue Nov 3, 2016
@manucorporat @brandyscarney
fix(action-sheet): Improve Action Sheet styles across all the platfor…
8d2c8b6 
…ms (#8736)

fixes #8663
@brandyscarney brandyscarney added this to the 2.0.0-rc.2 milestone Nov 3, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bensperry bensperry

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.2
Development

Successfully merging a pull request may close this issue.

fix(action-sheet): follows MD spec manucorporat/ionic
4 participants
@manucorporat @bensperry @brandyscarney @jgw96