feat: Monaco #1
Merged
feat: Monaco #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Plugin responses are now pretty printed. feat: Better dark mode support. fix: Addressed headers not respecting safe area insets. fix: Modal was actually being retained. It is now properly disposed.
Steven0351
commented
Dec 7, 2023
capacitor.config.ts
Outdated
There was a problem hiding this comment.
Didn't actually mean to commit these changes
trevor-lambert
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds monaco as the text editor, as well as a few tweaks and improvements. The headers were not respecting safe area insets causing issues when the debug app was not presented in a full screen Portal. The modal for invoking a plugin method was actually being retained after being dismissed as well.