Skip to content

Commit

Permalink
feat(deps): upgrade rollup, commonjs plugin
Browse files Browse the repository at this point in the history
upgrade rollup to v2.56.3 and `@rollup/plugin-commonjs` to v21.1.

this commit raises these libraries to the highest version as possible
without introducing breaking changes. v2.57 has a bug in it that
requires `@rollup/plugin-commonjs@22` for handling CJS-ESM interop.
that version of `@rollup/plugin-commonjs` requires
`@rollup/plugin-node-resolve@13`. however,
`@rollup/plugin-node-resolve@11` has changes that would be breaking
for existing users (see #5269)

in these various versions of both libraries, new flags have been added
to configure its output. for now, we continue to use the existing
configurations to prevent breaking users. these new configurations have
been recorded and tackled when we upgrade to newer versions of rollup
(as a part of stencil v5).

future upgrades will be slated to stencil v5.0.0.

STENCIL-595
  • Loading branch information
rwaskiewicz committed Jan 18, 2024
1 parent 6faf746 commit 1baacd7
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
20 changes: 10 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
},
"devDependencies": {
"@ionic/prettier-config": "^4.0.0",
"@rollup/plugin-commonjs": "15.1.0",
"@rollup/plugin-commonjs": "21.1.0",
"@rollup/plugin-json": "6.1.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-replace": "5.0.5",
Expand Down Expand Up @@ -119,7 +119,7 @@
"prettier": "3.2.2",
"prompts": "2.4.2",
"puppeteer": "^21.0.0",
"rollup": "2.42.3",
"rollup": "2.56.3",
"rollup-plugin-sourcemaps": "^0.6.3",
"semver": "^7.3.7",
"terser": "5.26.0",
Expand Down

0 comments on commit 1baacd7

Please sign in to comment.