Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 6, use project-based FAKE build instead of script #122

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

kMutagene
Copy link
Contributor

Hi there, In this PR i took a naïve go at upating the project to .NET 6:

  • updated the fornax tool to target .NET 6
  • migrated the FAKE build pipeline to a runnable project in the repo root. The reason for that was that i could not for the life of me make the build script work with updated dependencies via paket (some error about not finding Microsoft.Build.Framework). This project-based build is in my experience more stable than scripts. the SAFE stack for example uses the same approach.

I made sure that the tool works locally using the result of dotnet publish as well as the nuget package from the Pack target, i was however not sure about this line:

| 1 | 0 when compareNugetVersion sdkVersion net5 = -1 -> "netcoreapp3.1"

as the net5.0 tool would not run with 3.1 sdk anyways, but to mirror this pattern i left both 3.1 and 5.0 lines in that file intact.

@kMutagene
Copy link
Contributor Author

can i further help to get this merged?

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@TheAngryByrd TheAngryByrd merged commit a0f7a6e into ionide:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants