Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update watcher.fsx to support nullness #2055

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

isaacabraham
Copy link
Contributor

I have zero experience on the Ionide codebase, but saw that VSCode was giving nullness warnings on starting FSI e.g.

ionide.ionide-fsharp-7.22.0\watcher\watcher.fsx(48,34): warning FS3261: Nullness warning: The types 'System.Reflection.MemberInfo' and 'System.Reflection.MemberInfo | null' do not have compatible nullability.

This PR removes the warnings, but someone should review them to make sure that there hasn't been any semantic change in behaviour.

I also saw one apparently unnecessary transformation from Array to List to Seq which I have removed, for performance purposes.

I have zero experience on the Ionide codebase, but saw that VSCode was giving nullness warnings on starting FSI e.g.

```
ionide.ionide-fsharp-7.22.0\watcher\watcher.fsx(48,34): warning FS3261: Nullness warning: The types 'System.Reflection.MemberInfo' and 'System.Reflection.MemberInfo | null' do not have compatible nullability.
```

This PR removes the warnings, but someone should review them to make sure that there hasn't been any semantic change in behaviour.
@baronfel
Copy link
Contributor

baronfel commented Dec 6, 2024

Thanks @isaacabraham!

@baronfel baronfel merged commit 5fcad29 into ionide:main Dec 6, 2024
2 checks passed
@isaacabraham isaacabraham deleted the patch-1 branch December 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants