test: Fix DBaaS tests, mark 'connection_pooler' as Computed #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeatcu-ionos
force-pushed
the
fix-dbaas-tests
branch
from
71f4ec0
to
2174e26
Compare
adeatcu-ionos
requested review from
a team,
rmocanu-ionos,
mimihalescu,
cristiGuranIonos,
avirtopeanu-ionos,
glimberea,
cbeti-ionos and
digna-ionos
and removed request for
a team
| @@ -68,6 +68,7 @@ func resourceDbaasPgSqlCluster() *schema.Resource { | |||
| MaxItems: 1, | |||
| Description: "Configuration options for the connection pooler", | |||
| Optional: true, | |||
| Computed: true, | |||
There was a problem hiding this comment.
if this changed, we should add it to the changelog, also to the commit title
There was a problem hiding this comment.
@cristiGuranIonos yes, I forgot to add it in the CHANGELOG.md. This was supposed to be done in the PR for the connection_pooler attribute but I missed it. I'll add it in both CHANGELOG.md and title.
There was a problem hiding this comment.
@cristiGuranIonos done in e8383e7
adeatcu-ionos
force-pushed
the
fix-dbaas-tests
branch
from
2174e26
to
054b9e3
Compare
adeatcu-ionos
changed the title
adeatcu-ionos
force-pushed
the
fix-dbaas-tests
branch
from
054b9e3
to
e8383e7
Compare
digna-ionos
previously approved these changes
Sep 26, 2024
adeatcu-ionos
force-pushed
the
fix-dbaas-tests
branch
from
e8383e7
to
7675f14
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Checklist
feat:/fix:/doc:/test:/refactor:)