-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow custom urls for products that have location based urls #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiGuranIonos
requested review from
a team,
rmocanu-ionos,
mimihalescu,
avirtopeanu-ionos,
adeatcu-ionos,
glimberea,
cbeti-ionos and
digna-ionos
and removed request for
a team
November 12, 2024 14:47
mimihalescu
previously approved these changes
Nov 12, 2024
Co-authored-by: Mihaela Mihalescu <mihaela-violeta.mihalescu1@ionos.com>
Co-authored-by: Mihaela Mihalescu <mihaela-violeta.mihalescu1@ionos.com>
…terraform-provider-ionoscloud into fix/allow_custom_urls
digna-ionos
previously approved these changes
Nov 13, 2024
rmocanu-ionos
previously approved these changes
Nov 14, 2024
mimihalescu
previously approved these changes
Nov 14, 2024
Co-authored-by: Mihaela Mihalescu <mihaela-violeta.mihalescu1@ionos.com>
cristiGuranIonos
dismissed stale reviews from mimihalescu and rmocanu-ionos
via
November 14, 2024 13:45
947438d
mimihalescu
previously approved these changes
Nov 14, 2024
mimihalescu
previously approved these changes
Nov 14, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Checklist
feat:
/fix:
/doc:
/test:
/refactor:
)