This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
dynamic-counters example #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename list to counterIds
mpeyper
reviewed
Jun 21, 2018
|
|
||
| const initialState = { counterIds: ['Counter one', 'Counter two'] } | ||
|
|
||
| export const pageReducer = (state = initialState, action) => { |
There was a problem hiding this comment.
move to the reducers folder?
There was a problem hiding this comment.
Also not sure on the page name. counters?
There was a problem hiding this comment.
moved into reducers/index.js
un-defaulted previous reducer and renamed to counterInstanceReducer
renamed state slice from page to counters
renamed id array value from counterIds to allIds
mpeyper
reviewed
Jun 21, 2018
| } | ||
| } | ||
|
|
||
| class DynaCounter extends React.Component { |
There was a problem hiding this comment.
Move to the compnents folder. Could add a link to it directly in the README.
There was a problem hiding this comment.
moved and linked
|
Great work! Don't forget to add yourself as a contributor using the "Examples" option. |
mpeyper
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another example, based on redux-saga/cancellable-counters.
This example demonstrates a dynamic list of dynostore dynamic components.