Skip to content
This repository has been archived by the owner on Apr 11, 2019. It is now read-only.

Update to the waves extremal analysis notebook #139

Merged
merged 7 commits into from
Aug 18, 2014

Conversation

Bobfrat
Copy link
Contributor

@Bobfrat Bobfrat commented Aug 7, 2014

  • Clean up notebook
  • Use PYOOS to extract SOS data
  • Use NetCDF4 to extract waves directly from DAP endpoint
  • Read WIS data from JSON file that contains all of the WIS stations and annual maximums
  • Return period plots from Obs data and WIS data

- Clean up notebook
- Use PYOOS to extract SOS data
- Use NetCDF4 to extract directly from DAP endpoint
- Read WIS data from JSON file that contains all of the WIS stations and
  annual maximums
@Bobfrat
Copy link
Contributor Author

Bobfrat commented Aug 8, 2014

View the notebook here

-Add timer to some of the more computationally extensive blocks of code
-Reorganize the flow of the notebook to better tell the story
Conflicts:
	Theme_2_Extreme_Events/Scenario_2A_Coastal_Inundation/Scenario_2A_Extremes_Waves/Scenario_2A_Waves.ipynb
	Theme_2_Extreme_Events/Scenario_2A_Coastal_Inundation/Scenario_2A_Extremes_Waves/Scenario_2A_Waves.py
	Theme_2_Extreme_Events/Scenario_2A_Coastal_Inundation/Scenario_2A_Extremes_Waves/utilities.py
hs = nc.variables['wave_height']
hs_data = np.array(nc.variables['wave_height'][:,0,0])
# Replace fill values with NaN
hs_data[hs_data==hs._FillValue] = numpy.nan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be np.nan to stay consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed it!

@benjwadams
Copy link
Contributor

In conda_requirements.txt, the pyoos version is not specified. conda's latest version for pyoos as of this posting appears to be 0.61, compared with 0.62 for pip's package.

Attempting to filter using a BBox in 0.61 returns a message that bbox filtering is not implemented.

Here are the lines that create the filter and call the collector:
https://github.com/Bobfrat/system-test/blob/extreme_waves/Theme_2_Extreme_Events/Scenario_2A_Coastal_Inundation/Scenario_2A_Extremes_Waves/Scenario_2A_Waves.py#L181-L184

See the diff between 0.6.1 and 0.6.2 for the problem:
ioos/pyoos@0.6.1...0.6.2

Perhaps we should bump the pyoos version used by conda to 0.6.2.

@benjwadams
Copy link
Contributor

Runs properly here. @birdage, care to give a quick run through before merging?

birdage added a commit that referenced this pull request Aug 18, 2014
Update to the waves extremal analysis notebook
@birdage birdage merged commit 2c6aa79 into ioos:master Aug 18, 2014
@Bobfrat Bobfrat deleted the extreme_waves branch August 21, 2014 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants