refactor bpf histogram indexing #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous BPF histogram indexing was based on a reduction of the algorithm in an older version of the histogram crate that had both an a and b component. The latest histogram crate replaced those with a single grouping power. This change brings the indexing more in-line with the Rust version. Specific reductions and optimizations are made based on the specific values that we use throughout Rezolus. We also add indexing for grouping powers 4, 5, and 6 so that in the future we can use lower-resolution histograms for cases where we are doing per-group histograms (eg: per group of PIDs/TIDs) and would otherwise be adding a fair amount of memory footprint to Rezolus to enable scoped histograms.
Adds logging for the BPF program instruction counts when debug log is enabled.
brayniac
force-pushed
the
bpf-histograms
branch
from
734bd09
to
e5ad20f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous BPF histogram indexing was based on a reduction of the algorithm in an older version of the histogram crate that had both an a and b component. The latest histogram crate replaced those with a single grouping power.
This change brings the indexing more in-line with the Rust version. Specific reductions and optimizations are made based on the specific values that we use throughout Rezolus.