fix: bugfix for cpu sampler #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we use the proc_cpuinfo sampler on systems that do not report a per processor frequency, the sampler will panic with a divide by zero. This change fixes the logic so that we avoid a divide by zero when /proc/cpuinfo doesn't parse as we expect. It also changes the logic on how we count the number of online cores to get a count even when the system doesn't report core frequencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use the proc_cpuinfo sampler on systems that do not report a per processor frequency, the sampler will panic with a divide by zero.
This change fixes the logic so that we avoid a divide by zero when /proc/cpuinfo doesn't parse as we expect. It also changes the logic on how we count the number of online cores to get a count even when the system doesn't report core frequencies.