Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make BPF non-optional on Linux #336

Merged
merged 4 commits into from
Sep 13, 2024
Merged

make BPF non-optional on Linux #336

merged 4 commits into from
Sep 13, 2024

Conversation

brayniac
Copy link
Contributor

Problem

Previously, we allow for BPF to be optionally enabled and provide
transparent fall-back to non-BPF samplers if BPF initialization fails.
This can lead to uncertainty around metric meaning since it makes
the data provenance unclear. Further, the sampler overhead depends
on whether the BPF or fall-back sampler is used with much higher
costs for non-BPF samplers.

Solution

Changes BPF to be non-optional on Linux. Drops fall-back samplers
so that metric provenance is clear and so sampler overhead is
consistent.

Result

A simpler configuration and consistent data provenance and
sampler overheads.

Changes BPF to be non-optional on Linux. Drops fall-back samplers
so that metric provenance is clear and so sampler overhead is
consistent.
@brayniac brayniac merged commit 72f79d9 into iopsystems:main Sep 13, 2024
12 checks passed
@brayniac brayniac deleted the bpf branch September 13, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant