feat: allow enabling/disabling of samplers #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds configuration options that allow for enabling or disabling of samplers.
mihirn
reviewed
Oct 17, 2023
mihirn
reviewed
Oct 17, 2023
mihirn
reviewed
Oct 17, 2023
| } else { | ||
| Box::new(Snmp::new(config)) | ||
| Box::new(Nop::new(config)) |
There was a problem hiding this comment.
Curious as to what the difference between Box::new(Nop {}) and this line is.
There was a problem hiding this comment.
No real difference, but I think standardizing on using the constructor instead of directly instantiating the struct is cleaner and makes it easier to make changes to the no-op sampler later if needed.
mihirn
reviewed
Oct 17, 2023
mihirn
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration options that allow for enabling or disabling of samplers.