feat: add sampler for Rezolus itself #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds sampling of the resource utilization of Rezolus itself.
mihirn
reviewed
Oct 24, 2023
src/samplers/rezolus/stats.rs
Outdated
| )] | ||
| pub static RU_UTIME: LazyCounter = LazyCounter::new(Counter::default); | ||
|
|
||
| histogram!( |
There was a problem hiding this comment.
Curious: is defining both of them separately the same as counter_with_histogram!?
There was a problem hiding this comment.
It is. I switched over to the convenience macros for all these stats. If we start using labels, we'll need to go with the previous approach to add that metadata.
mihirn
reviewed
Oct 24, 2023
mihirn
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sampler to gather basic resource utilization metrics for Rezolus itself.