Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subscriptions.md #518

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Update subscriptions.md #518

merged 3 commits into from
Sep 8, 2024

Conversation

legendary-creeper
Copy link
Contributor

@legendary-creeper legendary-creeper commented Jul 30, 2024

Added Safebrowsing for Minecrafters 🛡️⛏️ to the subscriptions page, I've added it to the "Others" section since I though it would fit their the most.

Added Minecraft Safebrowsing Filterlist
@RubenKelevra
Copy link
Contributor

I don't think it fits the "Others" category - which contains a list of blocklists and a personal blacklist. I think it would be better to create a new category for this.

Btw: Nice work!

@legendary-creeper
Copy link
Contributor Author

I don't think it fits the "Others" category - which contains a list of blocklists and a personal blacklist. I think it would be better to create a new category for this.

Btw: Nice work!

I appreciate your feedback :)

Would would you propose as a new category?

@RubenKelevra
Copy link
Contributor

How about just "Games" or "Gaming"?

@aug-dev
Copy link
Contributor

aug-dev commented Aug 10, 2024

How about just "Games" or "Gaming"?

I think this is a good idea.

It's general enough and likely to be expanded later with new blacklists.

@iorate
Copy link
Owner

iorate commented Aug 18, 2024

@legendary-creeper If you agree that it is appropriate to place your subscription under the "Games" or "Gaming" category (or another new category), please update your pull request accordingly.

Updated the link to the rebranded version
@legendary-creeper
Copy link
Contributor Author

@legendary-creeper If you agree that it is appropriate to place your subscription under the "Games" or "Gaming" category (or another new category), please update your pull request accordingly.

I apologize for the delayed response. I agree with this idea and will update the pull request accordingly.

- Small changes to the description
- Added the "Gaming" category
- Updated the file to the most recent version
@iorate iorate merged commit 5e936e2 into iorate:master Sep 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants