[rostwitter] Add error_code to check error (#6)

iory · Sep 22, 2022 · 30faf99 · 30faf99
1 parent 46123bf
commit 30faf99
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/rostwitter/python/rostwitter/twitter.py b/rostwitter/python/rostwitter/twitter.py
@@ -60,16 +60,14 @@ def _request_url(self, url, verb, data=None):
 
     def _check_post_request(self, request):
         valid = True
-        if request.status_code == 200:
+        if request.status_code != 200:
             data = simplejson.loads(request.content)
+            rospy.logwarn('post tweet failed. status_code: {}'
+                          .format(request.status_code))
             if 'errors' in data:
                 for error in data['errors']:
                     rospy.logwarn('Tweet error code: {}, message: {}'
                                   .format(error['code'], error['message']))
-                valid = False
-        else:
-            rospy.logwarn('post tweet failed. status_code: {}'
-                          .format(request.status_code))
             valid = False
         if valid:
             return data