Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support iPhone XS, iPhone XS Max and iPhone XR #236

Merged
merged 6 commits into from
Dec 12, 2018

Conversation

EtienneLem
Copy link

Addresses #235

Basically always toLowerCase device names when comparing, because depending on where the device name comes from there are many different formatting, i.e.:

  • iPhone Xs Max
  • iPhone XS Max
  • iPhone XS MAX

Also normalized the ʀ character (R != ʀ). Comparing is always false otherwise even when toLowerCase().

Note for Cordova users:

Until this is merged / released and Cordova updates its dependencies, you may want to add ios-sim to your devDependencies and replace in your workflow:

cordova run --target=DEVICE_TYPE_ID

by

ios-sim launch platforms/ios/build/emulator/YOUR_APP.app --devicetypeid=DEVICE_TYPE_ID

@shazron
Copy link

shazron commented Dec 11, 2018

I just integrated #239 for ES6 support which is failing your changes. Rebase from master, thanks!

@shazron shazron added this to the 8.0 milestone Dec 11, 2018
@shazron
Copy link

shazron commented Dec 11, 2018

No need for rebase, I did it through Github. Now your PR is failing the eslint check, can you do:

npm install
npm run eslint -- --fix

@EtienneLem
Copy link
Author

Done 🤘

@shazron shazron merged commit 5dc4c8a into ios-control:master Dec 12, 2018
@brodycj
Copy link

brodycj commented Dec 12, 2018

Thanks @EtienneLem for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants