Support iPhone XS, iPhone XS Max and iPhone XR #236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #235
Basically always
toLowerCase
device names when comparing, because depending on where the device name comes from there are many different formatting, i.e.:Also normalized the ʀ character (
R != ʀ
). Comparing is always false otherwise even whentoLowerCase()
.Note for Cordova users:
Until this is merged / released and Cordova updates its dependencies, you may want to add ios-sim to your
devDependencies
and replace in your workflow:by