Consolidate git actions into commit-check script

.github/workflows/commit-check.yml

@@ -0,0 +1,26 @@
+name: commit-checks
+
+on:
+  pull_request:
+    branches:
+      - 'main'
+      - 'preview-[0-9]+\.[0-9]+\.[0-9]+'
+    paths-ignore:
+      - '.gitignore'
+      - '*.md'
+  push:
+    branches:
+      - 'main'
+      - 'gh-actions*'
+
+jobs:
+  all_tests:
+    runs-on: ubuntu-latest
+    name: 'commit-checks'
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+
+      - name: Run all tests
+        run: scripts/commit-check

.github/workflows/version-increment.yml

@@ -0,0 +1,26 @@
+name: version-increment
+
+on:
+  pull_request:
+    branches:
+      - 'main'
+    paths-ignore:
+      - '.gitignore'
+      - '*.md'
+  push:
+    branches:
+      - 'gh-actions*'
+
+jobs:
+  helm:
+    runs-on: ubuntu-latest
+    name: 'version-increment-check'
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+
+      - uses: helm/chart-testing-action@v2.3.1
+
+      - name: Run chart-testing (check-version-increment)
+        run: ct lint --config .github/config/ct-version-increment.yml --target-branch ${{ github.event.repository.default_branch }}

scripts/commit-check

@@ -1,16 +1,47 @@
 #!/usr/bin/env bash
-# commit-check - Pre-commit checks
 
-set -e -o pipefail
+# This script runs all commit checks EXCEPT for checking that the version is
+# correctly incermented, which is done via a seperate github action.
 
+set -e
+
+function cleanup()
+{
+    echo
+    echo "Cleaning up..."
+    if [[ -d $TMP_VENV ]]; then
+        rm -r "$TMP_VENV"
+    fi
+}
+
+trap cleanup EXIT
+
+#=====================================================
+# Run checks
+#=====================================================
 
 FAILURES=0
 
+echo "Setting up python venv..."
+TMP_VENV=$(mktemp -d -t venv.XXXXXX)
+python3 -m venv "$TMP_VENV"
+"$TMP_VENV"/bin/pip install --upgrade pip
+"$TMP_VENV"/bin/pip install PyYAML
 
+echo
+echo "Running version-increment dependency check"
+if ! ./scripts/check-dependency-version-increment; then
+    echo "Version-increment dependency check failed, check output and fix issues." >&2
+    FAILURES=$((FAILURES+1))
+else
+    echo "Version-increment dependency check passed."
+fi
+
+echo
 echo "Running helm lint..."
 args=("--set" "image.repository=repository" "--set" "image.tag=latest")
 error=false
-for chart in charts/*; do
+for chart in charts/{xrd-vrouter,xrd-control-plane}; do
     pushd "$chart"
     if ! (helm dependency update && helm lint "${args[@]}"); then
         error=true
@@ -19,17 +50,43 @@ for chart in charts/*; do
 done
 if [ $error = true ]; then
     FAILURES=$((FAILURES+1))
-    echo "helm lint failed, check output and fix errors" >&2
+    echo "Helm lint failed, check output and fix errors" >&2
+else
+    echo "Helm lint passed."
 fi
 
-
 echo
 echo "Running shellcheck..."
 if ! shellcheck scripts/{chart-releaser,commit-check}; then
-    echo "shellcheck failed, check output and fix issues." >&2
+    echo "Shellcheck failed, check output and fix issues." >&2
     FAILURES=$((FAILURES+1))
+else
+    echo "Shellcheck passed."
 fi
 
+podman build tests/ -t helm-tests --network host
+
+echo
+echo "Running Control Plane unit tests..."
+if ! podman run -v "$PWD/:/charts" helm-tests bats tests/ut/xrd-control-plane; then
+    echo "Control Plane unit tests failed, check output and fix issues." >&2
+    FAILURES=$((FAILURES+1))
+else
+    echo "Control Plane unit tests passed."
+fi
+
+echo
+echo "Running vRouter unit tests..."
+if ! podman run -v "$PWD/:/charts" helm-tests bats tests/ut/xrd-vrouter; then
+    echo "vRouter unit tests failed, check output and fix issues." >&2
+    FAILURES=$((FAILURES+1))
+else
+    echo "vRouter unit tests passed."
+fi
+
+#=====================================================
+# Final steps
+#=====================================================
 
 echo
 if ((FAILURES > 0)); then
@@ -38,4 +95,4 @@ if ((FAILURES > 0)); then
 else
     echo "SUCCESS: All passed!"
     exit 0
-fi
+fi