Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIP 29 compliance #1306

Merged
merged 7 commits into from
Mar 31, 2022
Merged

TIP 29 compliance #1306

merged 7 commits into from
Mar 31, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Mar 30, 2022 •
edited
Loading

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-message Working Group - Message c-feature Category - Feature e-medium Experience - Medium p-high Priority - High n-shimmer Network - Shimmer labels Mar 30, 2022
@thibault-martinez thibault-martinez added this to the v1.0 milestone Mar 30, 2022
bingyanglin
bingyanglin previously approved these changes Mar 30, 2022
View reviewed changes
pvdrz
pvdrz previously approved these changes Mar 30, 2022
View reviewed changes
@grtlr grtlr linked an issue Mar 30, 2022 that may be closed by this pull request
[TIP-29] Update milestone payload #1294
Closed
@grtlr
Copy link
Contributor

grtlr commented Mar 30, 2022

This closes #1294, right?

@thibault-martinez thibault-martinez dismissed stale reviews from pvdrz and bingyanglin via 0458eca March 31, 2022 08:10
grtlr
grtlr previously approved these changes Mar 31, 2022
View reviewed changes
@samuel-rufi samuel-rufi self-requested a review March 31, 2022 09:08
@thibault-martinez thibault-martinez merged commit 0feeaff into iotaledger:shimmer-develop Mar 31, 2022
@thibault-martinez thibault-martinez deleted the tip-29 branch March 31, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingyanglin bingyanglin bingyanglin approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@grtlr grtlr grtlr approved these changes

@pvdrz pvdrz pvdrz left review comments

Assignees
No one assigned
Labels
c-feature Category - Feature e-medium Experience - Medium n-shimmer Network - Shimmer p-high Priority - High wg-message Working Group - Message
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

[TIP-29] Update milestone payload
5 participants
@thibault-martinez @grtlr @samuel-rufi @pvdrz @bingyanglin