Skip to content

Commit

Permalink
Remove dependency on identity_core default features
Browse files Browse the repository at this point in the history
`identity_did` and `identity_document` depend on `identity_core` but do
not turn off default features. This means that these crates cannot be
compiled for `wasm32-unknown-unknown` without a dependency on `js-sys`.

Given the default features are not required, removing them makes these
crates compatible across a wider range of compilation targets.
  • Loading branch information
frederikrothenberger committed Sep 4, 2024
1 parent 84f1b7e commit 7b8676c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion identity_did/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ description = "Agnostic implementation of the Decentralized Identifiers (DID) st
[dependencies]
did_url_parser = { version = "0.2.0", features = ["std", "serde"] }
form_urlencoded = { version = "1.2.0", default-features = false, features = ["alloc"] }
identity_core = { version = "=1.3.1", path = "../identity_core" }
identity_core = { version = "=1.3.1", path = "../identity_core", default-features = false }
serde.workspace = true
strum.workspace = true
thiserror.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion identity_document/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ description = "Method-agnostic implementation of the Decentralized Identifiers (

[dependencies]
did_url_parser = { version = "0.2.0", features = ["std", "serde"] }
identity_core = { version = "=1.3.1", path = "../identity_core" }
identity_core = { version = "=1.3.1", path = "../identity_core", default-features = false }
identity_did = { version = "=1.3.1", path = "../identity_did" }
identity_verification = { version = "=1.3.1", path = "../identity_verification", default-features = false }
indexmap = { version = "2.0", default-features = false, features = ["std", "serde"] }
Expand Down

0 comments on commit 7b8676c

Please sign in to comment.