Skip to content

Commit

Permalink
Fix outstanding TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
PhilippGackstatter committed Jul 7, 2023
1 parent fbc6469 commit 9ff1ed1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions identity_jose/src/jwk/key_params.rs
Original file line number Diff line number Diff line change
Expand Up @@ -278,19 +278,19 @@ impl JwkParamsRsa {
&& self.dp.is_none()
&& self.dq.is_none()
&& self.qi.is_none()
// TODO: `oth` consists of multiple fields; check individually?
&& self.oth.is_none()
}

/// Returns `true` if _all_ private key components of the key are set, `false` otherwise.
///
/// Since the `oth` parameter is optional in a private key, its presence is not checked.
pub fn is_private(&self) -> bool {
self.d.is_some()
&& self.p.is_some()
&& self.q.is_some()
&& self.dp.is_some()
&& self.dq.is_some()
&& self.qi.is_some()
&& self.oth.is_some()
}
}

Expand Down

0 comments on commit 9ff1ed1

Please sign in to comment.