Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Remove Storage::set_password #720

Closed
7 tasks
cycraig opened this issue Mar 16, 2022 · 0 comments · Fixed by #733
Closed
7 tasks

[Task] Remove Storage::set_password #720

cycraig opened this issue Mar 16, 2022 · 0 comments · Fixed by #733
Assignees
Labels
Removed Feature removal that requires a major release. Part of "Removed" section in changelog
Milestone

Comments

@cycraig
Copy link
Contributor

cycraig commented Mar 16, 2022

Description

Remove the set_password() function from the account Storage interface.

Motivation

Password management is specific to Stronghold right now and should be handled by the Stronghold wrapper or its library rather than requiring that all Storage implementers deal with it.

Resources

This is a sub-task extracted from:

To-do list

  • Remove Storage::set_password

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • The feature or fix is implemented in Rust and across all bindings whereas possible.
  • The feature or fix has sufficient testing coverage
  • All tests and examples build and run locally as expected
  • Every piece of code has been document according to the documentation guidelines.
  • If conceptual documentation (mdbook) and examples highlighting the feature exist, they are properly updated.
  • If the feature is not currently documented, a documentation task Issue has been opened to address this.
@cycraig cycraig added the Removed Feature removal that requires a major release. Part of "Removed" section in changelog label Mar 16, 2022
@cycraig cycraig added this to the v0.5 Features milestone Mar 16, 2022
@abdulmth abdulmth self-assigned this Mar 18, 2022
@abdulmth abdulmth linked a pull request Mar 18, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removed Feature removal that requires a major release. Part of "Removed" section in changelog
Projects
Development

Successfully merging a pull request may close this issue.

2 participants