Remove Storage::set_password
#733
Conversation
abdulmth
added
Wasm
abdulmth
changed the title
set-password from StorageStorage::set_password
| @@ -16,10 +16,6 @@ export class Stronghold implements Storage { | |||
| return stronghold | |||
| } | |||
|
|
|||
| public async setPassword(encryptionKey: Uint8Array) { | |||
There was a problem hiding this comment.
I assume we still need this to set the stronghold password, although it is not part of the interface anymore.
There was a problem hiding this comment.
I agree, thanks Eike.
There was a problem hiding this comment.
It's not required because we set the password once during construction. This does not really suffice in the current stronghold, because the password expires after some time. This is also the case in Rust, though. Once we have migrated to the refactored stronghold, it will be fixed. I still think we can remove set_password in the NAPI bindings already.
There was a problem hiding this comment.
Right, because we set it in the constructor initially, which is enough for the new stronghold version. How do we coordinate this?
There was a problem hiding this comment.
Coordinate the upgrade? Personally, I'd like to do it as soon as possible once the stronghold team gives the green light.
Edit: Should await the KeyLocation refactor, though.
There was a problem hiding this comment.
Or maybe worded differently: what is the effect if we merge it like this and do we need to wait for a new stronghold version for a potential (dev) release?
There was a problem hiding this comment.
what is the effect if we merge it like this
Sorry for the delay, had to re-understand how password expiration works. Actually, the default is that the password does not expire at all. Merging it like this is therefore fine, as we set the password during construction, and then we don't need to set it again.
do we need for a new stronghold version for a potential (dev) release?
I don't think we need it. However, I can't guarantee that there is not going to be a breaking change during the migration to the new version. That said, from doing the KeyLocation refactor and from what I know about the new version, at least I cannot say that there will definitely be anything broken after the migration.
There was a problem hiding this comment.
Thank you for clarifying. I was worried it would expire. So we can totally merge and do a dev release.
Let's discuss potential future breaking changes before 0.5.0 proper release.
| pub async fn set_password(&self, password: EncryptionKey) -> Result<()> { | ||
| self.snapshot.set_password(password).await?; | ||
| Ok(()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Why are we keeping this? Looks unused in Rust and all bindings.
Description of change
Remove the
set_password()function from the account Storage interface.Links to any relevant issues
fixes issue #720
Type of change
Add an
xto the boxes that are relevant to your changes.