-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature-gate Resolver
#1007
Feature-gate Resolver
#1007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but please take the PR out of draft mode so the CI runs.
I got an error in the Wasm bindings, which needed a Edit: the Wasm cargo update
to fix, since the Cargo.lock
versions of future
are conflicting. Not sure if that's just a local problem.Cargo.lock
is gitignored, unlike the Stronghold bindings one, so it should be fine.
$ cargo clippy
Updating crates.io index
error: failed to select a version for `futures`.
... required by package `iota-client v2.0.0-beta.3`
... which satisfies dependency `iota-client = "^2.0.0-beta.3"` of package `identity_iota_core v0.6.0 (/home/craig/Desktop/work/identity.rs/identity_iota_core)`
... which satisfies path dependency `identity_iota_core` (locked to 0.6.0) of package `identity_iota v0.6.0 (/home/craig/Desktop/work/identity.rs/identity_iota)`
... which satisfies path dependency `identity_iota` (locked to 0.6.0) of package `identity_wasm v0.6.0 (/home/craig/Desktop/work/identity.rs/bindings/wasm)`
versions that meet the requirements `^0.3.24` are: 0.3.24
all possible versions conflict with previously selected packages.
previously selected package `futures v0.3.21`
... which satisfies dependency `futures = "^0.3"` (locked to 0.3.21) of package `identity_iota_core v0.6.0 (/home/craig/Desktop/work/identity.rs/identity_iota_core)`
... which satisfies path dependency `identity_iota_core` (locked to 0.6.0) of package `identity_iota v0.6.0 (/home/craig/Desktop/work/identity.rs/identity_iota)`
... which satisfies path dependency `identity_iota` (locked to 0.6.0) of package `identity_wasm v0.6.0 (/home/craig/Desktop/work/identity.rs/bindings/wasm)`
failed to select a version for `futures` which could resolve this conflict
I think since we don't commit the Cargo.lock it should be okay? I didn't have the error locally and we don't have a very restrictive version for |
Description of change
Feature gate the resolver in
identity_iota
, and add client extension traits to the prelude.Links to any relevant issues
Follow up to #1000.
Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
cargo check
Change checklist
Add an
x
to the boxes that are relevant to your changes.