Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add revocation examples #1076

Merged
merged 8 commits into from
Nov 15, 2022
Merged

Add revocation examples #1076

merged 8 commits into from
Nov 15, 2022

Conversation

abdulmth
Copy link
Contributor

Description of change

Add example for revoking verifiable credentials in Rust and Wasm.

Links to any relevant issues

#1060

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

@abdulmth abdulmth added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Added A new feature that requires a minor release. Part of "Added" section in changelog Chore Tedious, typically non-functional change Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Nov 14, 2022
@abdulmth abdulmth added this to the v0.7 Features milestone Nov 14, 2022
@eike-hass
Copy link
Collaborator

I assume for Wasm the example needs to be added to the tests as well. For Rust that is automatic, right?

olivereanderson
olivereanderson approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@olivereanderson olivereanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Wrote a few comments.

@abdulmth abdulmth merged commit 7adda46 into main Nov 15, 2022
@abdulmth abdulmth deleted the chore/revocation-examples branch November 15, 2022 17:36
@abdulmth abdulmth self-assigned this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivereanderson olivereanderson olivereanderson approved these changes

Assignees

@abdulmth abdulmth

Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Chore Tedious, typically non-functional change Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
IOTA Identity - Framework Developments
Status: Done
Milestone
v0.7 Features
Development

Successfully merging this pull request may close these issues.
3 participants
@abdulmth @eike-hass @olivereanderson