-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy crates #1080
Merged
Merged
Remove legacy crates #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGackstatter
added
Chore
Tedious, typically non-functional change
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Patch
Change without affecting the API that requires a patch release. Part of "Patch" section in changelog
labels
Nov 16, 2022
4 tasks
olivereanderson
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT.
Thanks for taking the time to adapt identity-agent
.
Could you please test building the wiki on this branch before merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added
IotaDID::is_placeholder
which was required for the updatedidentity_agent
tests and seemed generally useful to have.Changed
identity_account
.examples_legacy
.identity_account_storage
exceptidentity_agent
onidentity_account
and re-add it to the rootCargo.toml
.bindings/wasm/src/account/
.stronghold-nodejs
bindings because it depended onidentity_account_storage
.Links to any relevant issues
n/a
Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
CI runs.
Change checklist
Add an
x
to the boxes that are relevant to your changes.