Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy crates #1080

Merged
merged 14 commits into from
Nov 21, 2022
Merged

Remove legacy crates #1080

merged 14 commits into from
Nov 21, 2022

Conversation

PhilippGackstatter
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter commented Nov 16, 2022

Description of change

Added

  • Add IotaDID::is_placeholder which was required for the updated identity_agent tests and seemed generally useful to have.

Changed

  • Remove identity_account.
  • Remove examples_legacy.
  • Remove most of identity_account_storage except
    • src/stronghold/* (Stronghold wrapper types)
    • src/types/encryption/* (encryption types)
    • src/utils/crypto.rs (PBKDF2 key derivation)
  • Remove dependency of identity_agent on identity_account and re-add it to the root Cargo.toml.
  • Remove most of bindings/wasm/src/account/.
  • Comment out CI checks for stronghold-nodejs bindings because it depended on identity_account_storage.

Links to any relevant issues

n/a

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

CI runs.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@PhilippGackstatter PhilippGackstatter added Chore Tedious, typically non-functional change Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Nov 16, 2022
@PhilippGackstatter PhilippGackstatter added this to the v0.7 Features milestone Nov 16, 2022
@PhilippGackstatter PhilippGackstatter marked this pull request as ready for review November 17, 2022 12:14
Copy link
Contributor

@olivereanderson olivereanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

Thanks for taking the time to adapt identity-agent.

Could you please test building the wiki on this branch before merging?

@PhilippGackstatter PhilippGackstatter merged commit 77df8ce into main Nov 21, 2022
@PhilippGackstatter PhilippGackstatter deleted the chore/remove-legacy-crates branch November 21, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants