Implement KeyIdStorage in Rust
#1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
added
Added
olivereanderson
approved these changes
Mar 1, 2023
|
With regards to the name of the trait I think we can decide on that later. |
11 tasks
PhilippGackstatter
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Looks good, thank you!
- As for the name, I think I agree that we can change it later if necessary.
- Another thing I remembered was that I believe we wanted to originally expose the storage error to the Wasm bindings, so we could convert the enum variants properly between Wasm and Rust. Doesn't have to be done in this PR and not sure if it's worthwhile and viable in the first place, just wanted to raise it.
added 6 commits
March 7, 2023 19:32
# Conflicts: # identity_storage/Cargo.toml
olivereanderson
approved these changes
Mar 13, 2023
4 tasks
PhilippGackstatter
changed the title
KeyIdStorage in RustKeyIdStorage in Rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add the
KeyIdStoragetrait as a way for savingKeyIds of verification method materials by introducingMethodDigestthat takes aVerificationMethod. This is an implementation of the issue #1126 with the difference thatIdentityStorageis named here asKeyIdStorage(to be discussed).KeyStorageErroris now refactored as genericStorageErrorfor bothKeyStorageandKeyIdStorage.Links to any relevant issues
fixes issue #1126.Type of change
Add an
xto the boxes that are relevant to your changes.