Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial PublicKeyJwk support #1143

Merged
merged 18 commits into from
Mar 14, 2023
Merged

Add initial PublicKeyJwk support #1143

merged 18 commits into from
Mar 14, 2023

Conversation

olivereanderson
Copy link
Contributor

@olivereanderson olivereanderson commented Mar 13, 2023

Description of change

This PR makes verification material described by publicKeyJwk representable in DID Documents. See the specification.

This PR also feature gates the diff logic.

What is not included in this PR

  • The new functionality introduced here has not been tested.
  • There are not enough checks ensuring JWK-based Verification methods with private key components cannot be constructed.

In order to iterate faster on the upcoming features I suggest we return to these items once we have an initial implementation of the new KMS API.

Links to any relevant issues

Part of #1103.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Runs under cargo test and builds the bindings without problems.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@olivereanderson olivereanderson self-assigned this Mar 13, 2023
@olivereanderson olivereanderson added Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog labels Mar 13, 2023
@olivereanderson olivereanderson added this to the v0.7 Features milestone Mar 13, 2023
@olivereanderson olivereanderson marked this pull request as ready for review March 13, 2023 20:31
identity_jose/src/jwk/diff/key.rs Show resolved Hide resolved
identity_jose/src/jwk/diff/key_operations.rs Show resolved Hide resolved
identity_jose/src/jwk/diff/key_params/mod.rs Show resolved Hide resolved
identity_jose/src/jwk/diff/key_type.rs Show resolved Hide resolved
Co-authored-by: Abdulrahim Al Methiab <31316147+abdulmth@users.noreply.github.com>
@olivereanderson olivereanderson merged commit f27b7ec into main Mar 14, 2023
@olivereanderson olivereanderson deleted the feat/public-key-jwk branch March 14, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Development

Successfully merging this pull request may close these issues.

2 participants