Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old Presentation type #1190

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Remove old Presentation type #1190

merged 6 commits into from
Jun 28, 2023

Conversation

abdulmth
Copy link
Contributor

@abdulmth abdulmth commented Jun 23, 2023 •
edited
Loading

Description of change

  • Removes the unsupported Presentation type and its validator from both rust and Wasm.
  • This PR also remove the old credential validator.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

@abdulmth abdulmth self-assigned this Jun 23, 2023
@abdulmth abdulmth added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Chore Tedious, typically non-functional change Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jun 23, 2023
@abdulmth abdulmth changed the title Remove old Presentation type [WIP] Remove old Presentation type Jun 23, 2023
@abdulmth abdulmth changed the title [WIP] Remove old Presentation type Remove old Presentation type Jun 26, 2023
PhilippGackstatter
PhilippGackstatter approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you also rename the CredentialValidator to JwtCredentialValidator and CredentialValidationOptions to JwtCredentialValidationOptions as part of this PR, so it's in line with the rest of the JWT-based structs? Thanks!

@abdulmth abdulmth merged commit 182190e into main Jun 28, 2023
@abdulmth abdulmth deleted the chore/remove-outdated-presentaion-type branch June 28, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippGackstatter PhilippGackstatter PhilippGackstatter approved these changes

Assignees

@abdulmth abdulmth

Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Chore Tedious, typically non-functional change Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdulmth @PhilippGackstatter