Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename JwtPresentation to Presentation #1200

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Conversation

abdulmth
Copy link
Contributor

@abdulmth abdulmth commented Jul 7, 2023

Description of change

Since JwtPrsentation is not generic and not tied to JWT, it's now renamed to Presentation.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abdulmth abdulmth self-assigned this Jul 7, 2023
@abdulmth abdulmth added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Chore Tedious, typically non-functional change Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jul 7, 2023
@abdulmth abdulmth added the Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog label Jul 7, 2023
subjectHolderRelationship: [
presentationHolderDID.toString(),
SubjectHolderRelationship.AlwaysSubject,
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

  • There are five instances of new JwtCredentialValidationOptions({}) in this and other examples that you could rewrite to new JwtCredentialValidationOptions(). Search for ({}) in the examples directory.
  • And we can rewrite all instances of JwtCredentialValidationOptions.default() to new JwtCredentialValidationOptions() as well in the examples.

We could consider removing the default method on {JwtCredentialValidationOptions, JwtPresentationValidationOptions, JwtPresentationOptions} and make the new-style pattern the default.

(Feel free to do in another PR as well, I just looked it up now and wanted to write it down.)

@abdulmth abdulmth merged commit c1f6171 into main Jul 7, 2023
11 of 12 checks passed
@abdulmth abdulmth deleted the chore/rename-jwt-presentation branch July 7, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Chore Tedious, typically non-functional change Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants