-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Proof
#1209
Improve Proof
#1209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please don't use _type
anywhere.
|
||
/// Returns the type of proof. | ||
#[wasm_bindgen(js_name = "type")] | ||
pub fn _type(&self) -> String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub fn _type(&self) -> String { | |
pub fn type_(&self) -> String { |
#[wasm_bindgen(js_class = Proof)] | ||
impl WasmProof { | ||
#[wasm_bindgen(constructor)] | ||
pub fn constructor(_type: String, properties: JsValue) -> Result<WasmProof> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub fn constructor(_type: String, properties: JsValue) -> Result<WasmProof> { | |
pub fn constructor(type_: String, properties: JsValue) -> Result<WasmProof> { |
|
||
impl Proof { | ||
/// Creates a new `Proof`. | ||
pub fn new(_type: String, properties: Object) -> Proof { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub fn new(_type: String, properties: Object) -> Proof { | |
pub fn new(type_: String, properties: Object) -> Proof { |
Description of change
Improve the
Proof
type inCredential
andPresentation
.Proof
now must include atype
property to enable matching different proof types during validation.