Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable legacy Firefox CDP support #1403

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

eike-hass
Copy link
Collaborator

@eike-hass eike-hass commented Aug 29, 2024

Description of change

Reenable Firefox CDP to allow cypress control

Links to any relevant issues

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

CI passing

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eike-hass eike-hass requested a review from a team as a code owner August 29, 2024 13:55
@eike-hass eike-hass added the No changelog Excludes PR from becoming part of any changelog label Aug 29, 2024
@eike-hass eike-hass merged commit 13f9987 into main Aug 30, 2024
13 checks passed
@eike-hass eike-hass deleted the chore/enable-firefox-cdp-support branch August 30, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants