-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace chrono
with time
#529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change.
parse
needs to be updated to normalise the timezone to UTC+0 as per the DID specification and Timestamp
needs more unit tests in general.
This isn't really a breaking change is it? No APIs are changed since we didn't expose |
There are a few breaking changes introduced in this PR: One can no longer convert a |
Good points, I missed the |
Co-authored-by: Craig Bester <craig.bester@iota.org>
Co-authored-by: Craig Bester <craig.bester@iota.org>
…y.rs into chore/migrate-to-time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Minor comments.
Co-authored-by: Craig Bester <craig.bester@iota.org>
Co-authored-by: Craig Bester <craig.bester@iota.org>
Co-authored-by: Craig Bester <craig.bester@iota.org>
Co-authored-by: Craig Bester <craig.bester@iota.org>
Description of change
This PR removes all our direct dependencies on the
chrono
crate and introduces a dependency ontime
instead.The changes introduced here are mainly visible internally in
identity-core
as I have tried to keep the changes to theTimestamp
API to a minimum.Links to any relevant issues
fixes issue #442
Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Runs under
cargo test
Change checklist
Add an
x
to the boxes that are relevant to your changes.