Change also_known_as
type to OrderedSet
#632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changes the
CoreDocument::also_known_as
field fromVec<Url>
toOrderedSet<Url>
to comply with the DID specification: https://www.w3.org/TR/did-core/#also-known-aswhere "set" is defined to be an
OrderedSet
: https://infra.spec.whatwg.org/#ordered-set .Besides the API changes, this may break DID Documents which have duplicate entries in their
alsoKnownAs
section.This also adds
IotaDocument::also_known_as_mut()
since previously there was no safe way to update the field fromIotaDocument
without going through the unsafecore_document_mut
.Changed
CoreDocument::also_known_as
field fromVec<Url>
toOrderedSet<Url>
.CoreDocument::also_known_as()
method return from&[Url]
to&OrderedSet<Url>
.CoreDocument::aslo_known_as_mut()
method return from&mut Vec<Url>
to&mut OrderedSet<Url>
.IotaDocument::also_known_as()
method return from&[Url]
to&OrderedSet<Url>
.Added
IotaDocument::also_known_as_mut()
method.Type of change
How the change has been tested
Unit tests and examples pass locally.
Change checklist