Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Wasm support dependent on
target_arch
rather than feature #666Make Wasm support dependent on
target_arch
rather than feature #666Changes from all commits
d506138
820c6b4
8bd2f57
d9d055f
4fb2341
550c7af
732ef27
ca92155
2cd5d0b
394117e
e3375ed
fb6d35a
8337519
0984eec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently
join
is still suggested to await both tasks but it really doesn't matter since it doesn't affect the parallelism as you demonstrated.https://docs.rs/tokio/latest/tokio/macro.join.html#runtime-characteristics
No changes requested, just wanted to drop a link to the quote.