Fix panic when parsing an IotaDID
with more than 2 method id segments
#758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This currently panics:
IotaDID::parse("did:iota:custom:random:H3C2AVvLMv6gmMNam3uVAjZpfkcJCwDwnZn6z3wXmqPV")
, due to entering unreachable code inSegments::network
. To fix this,IotaDID::check_method_id
should return an error when the number of segments of the method id is> 2
instead of> 3
.Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Added a test.
Change checklist
Add an
x
to the boxes that are relevant to your changes.