Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Storage to store arbitrary blobs #953

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Change Storage to store arbitrary blobs #953

merged 6 commits into from
Jul 26, 2022

Conversation

HenriqueNogara
Copy link
Contributor

Description of change

Allow storing arbitrary bytes in Storage.

Links to any relevant issues

closes #918

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Existing tests have been run

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@HenriqueNogara HenriqueNogara changed the title Feat/storing arbitrary bytes Storing arbitrary bytes Jul 20, 2022
@HenriqueNogara HenriqueNogara added Enhancement New feature or improvement to an existing feature Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jul 20, 2022
@HenriqueNogara HenriqueNogara marked this pull request as ready for review July 20, 2022 14:11
cycraig
cycraig reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@cycraig cycraig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, mostly on the use of ToJson/FromJson traits instead of serde_json.

Not sure if there's a better approach for versioning but I would be okay with this for now.

Aside: maybe change PR title to "Change Storage to store arbitrary blobs" for the changelog entry?

identity_account_storage/src/storage/stronghold.rs Outdated Show resolved Hide resolved
bindings/wasm/examples-account/src/custom_storage.ts Outdated Show resolved Hide resolved
bindings/wasm/src/account/storage/traits.rs Outdated Show resolved Hide resolved
identity_account/Cargo.toml Outdated Show resolved Hide resolved
identity_account/src/error.rs Outdated Show resolved Hide resolved
identity_account_storage/Cargo.toml Outdated Show resolved Hide resolved
identity_account_storage/src/storage/memstore.rs Outdated Show resolved Hide resolved
identity_account_storage/src/storage/traits.rs Outdated Show resolved Hide resolved
identity_account/src/types/identity_state.rs Outdated Show resolved Hide resolved
identity_account/src/types/identity_state.rs Outdated Show resolved Hide resolved
PhilippGackstatter
PhilippGackstatter reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, minor comments on errors and naming.

identity_account_storage/src/storage/traits.rs Outdated Show resolved Hide resolved
identity_account_storage/src/storage/traits.rs Outdated Show resolved Hide resolved
identity_account/src/types/identity_state.rs Outdated Show resolved Hide resolved
identity_account/src/error.rs Outdated Show resolved Hide resolved
identity_account/src/types/identity_state.rs Outdated Show resolved Hide resolved
bindings/stronghold-nodejs/src/stronghold.rs Outdated Show resolved Hide resolved
@HenriqueNogara HenriqueNogara changed the title Storing arbitrary bytes Change Storage to store arbitrary blobs Jul 25, 2022
cycraig
cycraig approved these changes Jul 25, 2022
View reviewed changes
bindings/stronghold-nodejs/src/stronghold.rs Outdated Show resolved Hide resolved
bindings/stronghold-nodejs/src/stronghold.rs Outdated Show resolved Hide resolved
@cycraig cycraig changed the title Change Storage to store arbitrary blobs Change Storage to store arbitrary blobs Jul 25, 2022
@HenriqueNogara HenriqueNogara merged commit f05fc56 into dev Jul 26, 2022
@HenriqueNogara HenriqueNogara deleted the feat/storing-arbitrary-bytes branch July 26, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cycraig cycraig cycraig approved these changes

@PhilippGackstatter PhilippGackstatter Awaiting requested review from PhilippGackstatter

Assignees
No one assigned
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Enhancement New feature or improvement to an existing feature Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Allow storing arbitrary bytes in Storage
3 participants
@HenriqueNogara @cycraig @PhilippGackstatter