-
Notifications
You must be signed in to change notification settings - Fork 31
Additional transactions in example #25
base: master
Are you sure you want to change the base?
Additional transactions in example #25
Conversation
Dockerfile
Outdated
@@ -0,0 +1,4 @@ | |||
FROM node:9.3.0-onbuild | |||
LABEL maintainer="j.innerbichler@gmail.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the commit that adds this from this PR?
.gitignore
Outdated
@@ -60,3 +60,4 @@ typings/ | |||
# dotenv environment variables file | |||
.env | |||
|
|||
package-lock.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-lock.json
shouldn't be ignored.
@@ -38,14 +39,15 @@ const createTransaction = (user, actions, close) => { | |||
// Distribute the remaining channel balance amongst the channel users | |||
// NOTE: YOU MUST PASS THE SETTLEMENT ADDRESSES ARRAY as 'actions' | |||
newTansfers = transfer.close(actions, user.flash.deposit) | |||
rootToUse = user.flash.root; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a test for this please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
run.sh
Outdated
@@ -0,0 +1 @@ | |||
docker build -t flash/test . && docker run -it --rm flash/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove from this PR as well?
Closed #24 because the commit is in this PR's history as well. |
No description provided.