Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Additional transactions in example #25

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jinnerbichler
Copy link
Contributor

No description provided.

Dockerfile Outdated
@@ -0,0 +1,4 @@
FROM node:9.3.0-onbuild
LABEL maintainer="j.innerbichler@gmail.com"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the commit that adds this from this PR?

.gitignore Outdated
@@ -60,3 +60,4 @@ typings/
# dotenv environment variables file
.env

package-lock.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json shouldn't be ignored.

@@ -38,14 +39,15 @@ const createTransaction = (user, actions, close) => {
// Distribute the remaining channel balance amongst the channel users
// NOTE: YOU MUST PASS THE SETTLEMENT ADDRESSES ARRAY as 'actions'
newTansfers = transfer.close(actions, user.flash.deposit)
rootToUse = user.flash.root;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a test for this please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

run.sh Outdated
@@ -0,0 +1 @@
docker build -t flash/test . && docker run -it --rm flash/test
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove from this PR as well?

@th0br0
Copy link

th0br0 commented Jan 17, 2018

Closed #24 because the commit is in this PR's history as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants