Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iota-indexer]: Add test cases for implemented JSON-RPC APIs #2148

Closed
12 tasks done
samuel-rufi opened this issue Aug 30, 2024 · 3 comments
Closed
12 tasks done

[iota-indexer]: Add test cases for implemented JSON-RPC APIs #2148

samuel-rufi opened this issue Aug 30, 2024 · 3 comments
Assignees
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.

Comments

@samuel-rufi
Copy link
Member

samuel-rufi commented Aug 30, 2024

Description

There are currently no tests in iota-indexer that test the Indexer implementations of the JSON-RPC API traits.

Tasks

Preview Give feedback
  1. team-infra team-sc-platform
    tomxey
  2. team-infra team-sc-platform
    tomxey
  3. team-infra team-sc-platform
    samuel-rufi
  4. team-infra team-sc-platform
    samuel-rufi
  5. team-infra team-sc-platform
    sergiupopescu199
  6. team-infra team-sc-platform
    sergiupopescu199
  7. team-infra team-sc-platform
    tomxey
  8. team-infra team-sc-platform
    sergiupopescu199
  9. team-infra team-sc-platform
    sergiupopescu199
  10. team-infra team-sc-platform
    samuel-rufi
  11. team-infra team-sc-platform
    tomxey
  12. team-infra team-sc-platform
    tomxey
@samuel-rufi samuel-rufi added sc-platform Issues related to the Smart Contract Platform group. infrastructure Issues related to the Infrastructure Team labels Aug 30, 2024
@kodemartin
Copy link
Contributor

kodemartin commented Sep 2, 2024

I think we should prioritize IndexerApi, ReadApi, ExtendedApi.

For the rest it would suffice to reach the same coverage as the iota-json-rpc-tests.

Note

iota-json-rpc-tests can be possibly used as a base, and refactored to use the Indexer JSON-RPC server.

@samuel-rufi samuel-rufi changed the title [Task (iota-indexer)]: Add test cases for implemented JSON-RPC APIs [Epic (iota-indexer)]: Add test cases for implemented JSON-RPC APIs Sep 2, 2024
@kodemartin
Copy link
Contributor

For the moments PRs resolving all these issues should target this feature branch: https://github.com/iotaledger/iota/tree/sc-platform/indexer-new-rpc-tests

@kodemartin
Copy link
Contributor

kodemartin commented Sep 9, 2024

I suggest that the new tests are added as integration tests in iota-indexer.

└── tests/
    ── rpc-tests/
        ├── main.rs
        └── extended_api.rs

@lzpap lzpap changed the title [Epic (iota-indexer)]: Add test cases for implemented JSON-RPC APIs [iota-indexer]: Add test cases for implemented JSON-RPC APIs Oct 14, 2024
@lzpap lzpap added this to the Testnet milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

No branches or pull requests

5 participants