fix: missing renames #1530
Merged
fix: missing renames #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muXxer
requested review from
msarcev,
alexsporn,
thibault-martinez,
DaughterOfMars,
fijter,
Dr-Electron and
a team
as code owners
|
✅ Vercel Preview Deployment is ready! |
| @@ -211,7 +211,7 @@ jobs: | |||
|
|
|||
| # This job ensures that Move unit tests are run if there are changes | |||
| # to Move code but not Rust code (If there are Rust changes, they | |||
| # will be run as part of a larger test iotate). | |||
| # will be run as part of a larger test suite). | |||
DaughterOfMars
approved these changes
Jul 31, 2024
lucas-tortora
approved these changes
Jul 31, 2024
|
✅ Vercel Preview Deployment is ready! |
|
✅ Vercel Preview Deployment is ready! |
miker83z
approved these changes
Jul 31, 2024
Thoralf-M
reviewed
Aug 1, 2024
Thoralf-M
reviewed
Aug 1, 2024
Thoralf-M
approved these changes
Aug 1, 2024
Dr-Electron
approved these changes
Aug 1, 2024
|
✅ Vercel Preview Deployment is ready! |
begonaalvarezd
approved these changes
Aug 1, 2024
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* fix: missing renames * fix: fmt with dprint + rustfmt * fix: false positive renames (iotate->suite) * fix: skip rustfmt for the comments in keytool tests
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* fix: missing renames * fix: fmt with dprint + rustfmt * fix: false positive renames (iotate->suite) * fix: skip rustfmt for the comments in keytool tests
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* fix: missing renames * fix: fmt with dprint + rustfmt * fix: false positive renames (iotate->suite) * fix: skip rustfmt for the comments in keytool tests
alexsporn
pushed a commit
that referenced
this pull request
Sep 9, 2024
* fix: missing renames * fix: fmt with dprint + rustfmt * fix: false positive renames (iotate->suite) * fix: skip rustfmt for the comments in keytool tests
marc2332
pushed a commit
that referenced
this pull request
Sep 10, 2024
* fix: missing renames * fix: fmt with dprint + rustfmt * fix: false positive renames (iotate->suite) * fix: skip rustfmt for the comments in keytool tests
Alex6323
added a commit
that referenced
this pull request
Nov 26, 2024
thibault-martinez
added a commit
that referenced
this pull request
Dec 4, 2024
* disable swap space allocation * update config-patch * temporarily disable report upload * upload coverage reports as Github artifacts * fix path * update Cargo.lock * temporarily disable slack bot notificaiton * update config-patch * clean up artifacts * also clean in between * fix * investigate seg faults during simtest * run only simtest * disable simtest; update grcov workflow * cleanup * clean up * nightly why not * archive html coverage report * test archiving * restructure * try release build * undo release build, undo restructure * try the hippie * fix path; include branch coverage again * only simtests one-by-one * only simtests one-by-one 2; increase retries * exclude segfaulting crates from coverage * really exclude segfaulting crates * bad docs * disable swap * ensure report creation * force success if report was generated * clean up the mess * remove grcov coverage workflow * more clean up * nit * merge nextest and simtest coverage * add llvm-cov dir * remove possibly corrupted .profraw files before report generation * use llvm-profdata tool installed by rustup * report subcommand * check llvm-profdata version * nightly please * . * bash fun * funny commits * hopefully fixed * more debug, increase retention * ensure correct toolchain * clean up * fix output dir * clean llvm-cov-target * increase workflow timeout * Upload code coverage report (#3896) * remove comment * fix path * clean up * profraw-only * temp disable simtest coverage * try to improve runtime speed during coverage computation * sudo apt-get * validity check notification * simplify * re-enable simtest * only simtest * clean env vars * nits * only code-coverage for workspace crates * optimize * ignore external crates source files * put option on the right command * simtests only: no debug info * debug log * re-enable nextest * re-enable debug symbols * reduce opt-level * reduce opt-level to 0 * refactor * env * fix env * pass as list to llvm-profdata * too bad * fix paths * nightly advanced infos * fix toolchain * can't have everything * try again * test if --branch caused the OOM * re-include simtests * disable debug symbols * single package * disable branch coverage * nit * publish to coveralls * set base-path * upload to codecov for comparison * relative paths then * wen better docs? * relative paths the hard way * ran into coveralls issue #1530 * upload to codecov with token * re-enable simtest coverage 😓 🙏 * don't fail if codecov upload fails * no nightly, fixes, cleanup, improvements * fix check * come on * sccache check * debug commands; use subshell * sccache + more echos * add Coveralls badge to README.md * bye codecov * fix config.toml extension Co-authored-by: DaughterOfMars <chloedaughterofmars@gmail.com> * rm badge * rm sscache install; mandatory corruption check * dprint * dprint Cargo.toml * run cargo_sort.py * chore(ci): clean version pin comments (#4317) * chore(ci): clean version pin comments * labeler * align action pinning * dprint * review * review 2 * reduce log output * rm backing up lcov.info --------- Co-authored-by: Thomas Shufps <shufps80@gmail.com> Co-authored-by: DaughterOfMars <chloedaughterofmars@gmail.com> Co-authored-by: Thibault Martinez <thibault@iota.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I was looking through the workflow files and found several missing renames there, as well as in some other crates.
Type of change
How the change has been tested
I didn't test the changes, because most of the renamed endpoints are dead ends anyway.
As long as the CI doesn't break down further, it should be fine.
Change checklist