Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iota-json-rpc-tests): add governance api tests #3143

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

samuel-rufi
Copy link
Member

@samuel-rufi samuel-rufi commented Oct 8, 2024

Description of change

Added the remaining GovernanceApi tests for the iota-json-rpc-tests crate.

It appeared that there is an issue in the unstaking and timelocked unstaking feature. The test_unstaking test and
test_timelocked_unstaking test provide coverage for the issue. Both tests have been ignored for now as further investigation is needed as it seems to be a more underlying issue to solve - which is outside of scope of this PR. Related tracking issue: #3007

Links to any relevant issues

Fixes #2917

Type of change

  • Tests

How the change has been tested

cargo simtest -p iota-json-rpc-tests --test governance_api

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@samuel-rufi samuel-rufi added sc-platform Issues related to the Smart Contract Platform group. infrastructure Issues related to the Infrastructure Team labels Oct 8, 2024
@samuel-rufi samuel-rufi self-assigned this Oct 8, 2024
@samuel-rufi samuel-rufi requested a review from a team as a code owner October 8, 2024 20:29
@sergiupopescu199 sergiupopescu199 self-requested a review October 9, 2024 09:30
Copy link
Contributor

@sergiupopescu199 sergiupopescu199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✨

@samuel-rufi samuel-rufi merged commit db8938c into develop Oct 10, 2024
28 of 33 checks passed
@samuel-rufi samuel-rufi deleted the l1sc/infra/remaining-governance-tests branch October 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task (Infrastructure)]: Add remaining GovernanceApi tests in iota-json-rpc-tests
3 participants