-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iota-json-rpc-tests): add governance api tests #3143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-rufi
added
sc-platform
Issues related to the Smart Contract Platform group.
infrastructure
Issues related to the Infrastructure Team
labels
Oct 8, 2024
tomxey
reviewed
Oct 9, 2024
tomxey
approved these changes
Oct 9, 2024
sergiupopescu199
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
infrastructure
Issues related to the Infrastructure Team
sc-platform
Issues related to the Smart Contract Platform group.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added the remaining
GovernanceApi
tests for theiota-json-rpc-tests
crate.It appeared that there is an issue in the unstaking and timelocked unstaking feature. The
test_unstaking
test andtest_timelocked_unstaking
test provide coverage for the issue. Both tests have been ignored for now as further investigation is needed as it seems to be a more underlying issue to solve - which is outside of scope of this PR. Related tracking issue: #3007Links to any relevant issues
Fixes #2917
Type of change
How the change has been tested
cargo simtest -p iota-json-rpc-tests --test governance_api
Change checklist