-
Notifications
You must be signed in to change notification settings - Fork 370
Conversation
@kwek20 see Travis build - it can't fetch
|
@alon-e Yes i'm aware, see questions: "Should we upload the doclet to JitPack, so that Travis can build the source?" I guess we have to? |
53bd709
to
5a47b4e
Compare
Hmmmm, this still isnt fixed: Havent gotten any of these solutions to work yet either. |
It looks good. Opened issue #1432 after playing around a bit. @kwek20 once buildkite is back up you just need to tell me which PR you want to merge first, this one or #1374 |
It's approved from my side. The issue was scoped to a specific definition and the site changed significantly since then. Jake and I will look at the layout and I'll create a subsequent issue if changes need to be made. This shouldn't be bloated up anymore. |
@GalRogozinski #1374 first please! Although its going to be a mess either way :D |
Description
Added doclet to dependencies
Added repo url as argument for doclet
Added Annotations at the methods we wish to document.
Modified some javadoc to work with the doclet. (no spaces in
<ul><li>, <p>
, etc)Fixes #1106
Fixes the IRI part of #1076.
The other half is work in progress: ledger/iri-mdx-doclet/issues/2
Reviewers can ignore every commit before
04df151
, this was merged, not rebased.Type of change
Checklist:
Questions
Should we upload the doclet to JitPack, so that Travis can build the source?
Can we link to a JitPack source when specifiying
<docletArtifact>
inside a<plugin>
?