-
Notifications
You must be signed in to change notification settings - Fork 370
Test: Updated TransactionTestUtils, its usage, and javadoc #1363
Conversation
@@ -91,7 +91,7 @@ public void requestTransaction(Hash hash, boolean milestone) throws Exception { | |||
* | |||
* It used when the queue capacity is reached, and new transactions would be dropped as a result. | |||
*/ | |||
// @VisibleForTesting | |||
//Package Private For Testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default method visibility: package level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karimodm What do you mean? If you're talking about the message, pretty sure @GalRogozinski told me to name it like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah talked with Gal, were going with the annotation now!
src/main/java/com/iota/iri/controllers/TransactionViewModel.java
Outdated
Show resolved
Hide resolved
Looks good, but some more fixes might be good since we are at it. |
208896e
to
f58d6f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please don't name the methods with "random"?
The reason is that randomness is the root of all evil in tests.
Currently the seed we are using is not really random:
private static Random seed = new Random(1);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. This will be merged once TIAB is up and running again
Description
Changes to unit tests required for the added unit tests in #1091
Type of change
Checklist: