Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Add spent addresses test #1489

Merged
merged 31 commits into from
Dec 9, 2019

Conversation

DyrellC
Copy link
Contributor

@DyrellC DyrellC commented Jun 8, 2019

Description

Add a regression test for spent addresses. This test ensures that a spent addresses are registered as spent from in three scenarios:

  1. As an unconfirmed transaction
  2. As a confirmed transaction
  3. After the transaction has been pruned from the db

Finishes #1442

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

Tests run on local nodes and on a minkube setup.

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@GalRogozinski
Copy link
Contributor

Waiting to merge #1505 before

@GalRogozinski
Copy link
Contributor

apparently there are conflicts @DyrellC

@iotaledger iotaledger deleted a comment Jul 22, 2019
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)
I like how most of the change is in Gherkin, meaning the regression framework is indeed in a good place.

Just one change request and one question

@GalRogozinski
Copy link
Contributor

Fails with BadApiResponse: 400 response from node: This operation cannot be executed: The subtangle has not been updated yet.

@DyrellC DyrellC force-pushed the add-spent-addresses-test branch from 366fe3b to fe16329 Compare September 16, 2019 04:28
@GalRogozinski
Copy link
Contributor

I see the test is passing...

I still had one request for a change in the test that wasn't yet completed. Besides that, all is well.

@iotaledger iotaledger deleted a comment Sep 29, 2019
@DyrellC DyrellC force-pushed the add-spent-addresses-test branch from e418078 to e476538 Compare October 4, 2019 16:58
@DyrellC DyrellC requested a review from GalRogozinski December 3, 2019 23:20
@DyrellC
Copy link
Contributor Author

DyrellC commented Dec 3, 2019

@galrogo Another buildkite failure that wasn't due to the tests. I've contacted Sadjy already regarding the service being down. Hopefully it's resolved by tomorrow and I can get this and 1584 passed via buildkite again as well

@GalRogozinski GalRogozinski merged commit 1527f77 into iotaledger:dev Dec 9, 2019
@GalRogozinski GalRogozinski mentioned this pull request May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants