-
Notifications
You must be signed in to change notification settings - Fork 370
Add spent addresses test #1489
Add spent addresses test #1489
Conversation
Waiting to merge #1505 before |
apparently there are conflicts @DyrellC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :-)
I like how most of the change is in Gherkin, meaning the regression framework is indeed in a good place.
Just one change request and one question
python-regression/tests/features/machine6/6_local_snapshots_tests.feature
Show resolved
Hide resolved
Fails with |
366fe3b
to
fe16329
Compare
I see the test is passing... I still had one request for a change in the test that wasn't yet completed. Besides that, all is well. |
e418078
to
e476538
Compare
@galrogo Another buildkite failure that wasn't due to the tests. I've contacted Sadjy already regarding the service being down. Hopefully it's resolved by tomorrow and I can get this and 1584 passed via buildkite again as well |
Description
Add a regression test for spent addresses. This test ensures that a spent addresses are registered as spent from in three scenarios:
Finishes #1442
Type of change
How Has This Been Tested?
Tests run on local nodes and on a minkube setup.
Checklist: